GDevelop
GDevelop copied to clipboard
4ian
Add CTRL+D shortcut to duplicate #6629
I corrected accelerator and grouped onDelete with onDuplicate. I also added a comment to the one above the instantiation of keyboardShortcutsRef. #6629
Hi @osmaneTKT, thanks for the changes. Could you clean your PRs ? You can close #6629 or update it with this new commit. It's starting to be a bit complicated to follow at this point 😅
@AlexandreSi, it's done. I wanted to ask if you think it will be merged because it will allow me to complete my course and show it to my professor, or if there are still other things to address.
I just realized that your 2 branches master and contribution should be merged.
You can do a cherry pick of the commit on master to put it on contribution.
Could you also rename duplicateObject ? it does not duplicate an object but an objectFolderOrObjectWithContext
Just my thoughts about this:
- Using the tree view shortcut makes sure the user is actually focusing the objects panel and not trying to duplicate something else
- In contrary to the global shortcut.
- But it cannot be customized as is.
- The same could be added for object groups for instance
So for me this is the way to go.
But to make this PR clean, I think the shortcut to rename an object should be transferred to the treeview keyboard shortcut instead of the global shortcut, ignoring the custom shortcuts users might have set.
So I'm not sure about what we should do. @Bouh wdyt?
Just my thoughts about this:
Using the tree view shortcut makes sure the user is actually focusing the objects panel and not trying to duplicate something else
- In contrary to the global shortcut.
- But it cannot be customized as is.
The same could be added for object groups for instance
So for me this is the way to go.
But to make this PR clean, I think the shortcut to rename an object should be transferred to the treeview keyboard shortcut instead of the global shortcut, ignoring the custom shortcuts users might have set.
So I'm not sure about what we should do. @Bouh wdyt?
I didn't know about the tree view shortcuts, if you think the best place is there, I agree with your choice. Be able to customize the shortcut is another need, which can be addressed later.
