GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Various JavaScript errors pop up

Open PascalLadalle opened this issue 2 years ago • 2 comments

It seems that since recently, people are getting pop-ups about JS errors.

In this case, the user (on v137) mentioned that the error shows when the available update notification comes. I asked him to disable the auto-update and restart, and the error stopped showing. image

In this case, the error pops every now and then. image

I wasn't able to reproduce the issue so far. I'll update if/when more reports come. 5 people have reported a similar issue so far.

PascalLadalle avatar Jun 22 '22 15:06 PascalLadalle

Pandako discussed this on the discord, it's happening to them even when they're not in a project, and they check for version updates.

Silver-Streak avatar Jun 23 '22 13:06 Silver-Streak

I've had this issue happen locally once as well. (it looks the same?)

Screenshot 2022-07-01 at 16 36 40

I'm wondering if this has appeared since the electron upgrade, which made it less permissive on events sending. It looks like it happens when electron is trying to send an event with: event.sender.send('xxx') and the sender of the IcpMainEvent has been destroyed. In my case, this was when I closed a preview, the debugger was trying to send the information that the debugger was closed. (race condition?)

We could ensure that the sender is always available with sender.isDestroyed() every time before calling send() but it feels like this is a monkey-patch of a bigger problem of a race condition.

ClementPasteau avatar Jul 01 '22 15:07 ClementPasteau