GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Add Camera zoom condition

Open Elairyx7301 opened this issue 3 years ago • 5 comments

I'm (still) working with the most basic tools when doing PRs etc. and I hope I will be able to change that soon but until then I'll have to bother you with a bit chaos. Also with that, I can't test the changes right away, sorry about all that. I have promised to work on this for quite some time so I wanted to give it a go.

@/AlexandreSi has already told me that the following files need changes: Core/GDCore/Extensions/Builtin/CameraExtension.cpp GDJS/GDJS/Extensions/Builtin/CameraExtension.cpp GDJS/Runtime/events-tools/cameratools.ts but I couldn't find what to change in .../events-tools/cameratools.ts, since all I could find was getters and setters and I see them not connected if the element is an action or condition or expression and export const getCameraZoom is already available in the file.

What am I missing?

Elairyx7301 avatar Jun 06 '22 13:06 Elairyx7301

Reverting some changes... (blame my not existent setup and workflow)

Elairyx7301 avatar Jun 06 '22 13:06 Elairyx7301

I hate everything about this :-x

Elairyx7301 avatar Jun 06 '22 13:06 Elairyx7301

See only those commits 7033138 ab3e10b

Elairyx7301 avatar Jun 06 '22 13:06 Elairyx7301

You're on the good track :) There is indeed nothing to change in cameratool.js, as the condition you're adding is using the same JavaScript function as the expression.

Were you able to test that your new condition is working?

4ian avatar Jun 07 '22 14:06 4ian

I'm sorry, I was not able to test it. I'm not using any tools for PRs other than the GitHub web version and I'm close to moving out and I might be able to set up a proper workflow etc. on the new computer eventually.

Elairyx7301 avatar Jun 07 '22 15:06 Elairyx7301