GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Multiple things

Open Bouh opened this issue 2 years ago • 15 comments

This is a bug report and a list of thing to polish before the next update.

  • [x] In Dark mode, Solarized and new GDevelop default Dark, when I move an event the revamped indicator have a bad contrast (@ClementPasteau fixed) image image

  • [x] With the new theme, panel have no more colors. image

  • [ ] The bold font on the buttons bothers me, I feel like I'm squinting, it's nice, but I feel like it makes me more tired to read. image image image image

  • [x] Cancel is unuseable (@ClementPasteau fixed - cannot be canceled so removed button) image

  • [x] The cursor isn't consistent (@ClementPasteau fixed) image

  • [x] Click on a tag, and you go to a list of all items with the tag, but this tag isn't in the search bar, or in filters. (@D8H fixed) tag

  • [x] I don't remember adding Laser Shooter and Laser in this GDevelop Platformer pack and after a check there is no sprite with this name in the folder. Maybe there is a problem in the asset store. (@D8H fixed) image

Nothing more to said on the new DND, it works like a charm, CTRL+Z too, the new theme have nices new shapes :D And the Asset Store is just amazing!

Bouh avatar Jun 03 '22 19:06 Bouh

  • [x] Sharp corner (edit by @4ian: fixed) image image

  • [x] ~~Time to time on I got a the focus on the canvas. Focus which is visible by the orange border, this focus thing is purely a web-ish thing, and have no sense there.~~ edit by 4ian: fixed! image

Bouh avatar Jun 03 '22 20:06 Bouh

  • [x] Can't drag an event "right" from outside a ForEach() event and into the ForEach()

https://user-images.githubusercontent.com/8879811/171982658-6a942b2d-ca9e-4e84-9fbe-1a391b8e99f1.mp4

tristanbob avatar Jun 04 '22 04:06 tristanbob

  • [x] Cannot drag events "left" to the same level as parent Event Group (sometimes works though)

https://user-images.githubusercontent.com/8879811/171977917-bba9ae0e-0518-4475-aaad-23543d2d13a9.mp4

tristanbob avatar Jun 04 '22 04:06 tristanbob

Regarding your 2 comments @tristanbob

I believe it is slightly tricky to handle and create "drop zones" that match the behavior you're trying to achieve. The feature works though, you just have to drop the event in the correct place. I've highlighted the "drop zones" in my environment so you can see how to achieve this better.

  • In order to drop inside a foreach that already has an event, your mouse has to hover at the beginning of the last even of that foreach loop.

https://user-images.githubusercontent.com/4895034/172145128-fceac38c-578c-4ef5-9568-e40ddbafdba6.mov

  • In order to drop at the same level as an Event Group, you have to drop below the event group (as it contains other events, you technically cannot drop just below it, even if it is the only event)

https://user-images.githubusercontent.com/4895034/172145401-16ab04c8-438c-4d0d-a4d8-dd411bfccd87.mov

ClementPasteau avatar Jun 06 '22 10:06 ClementPasteau

On the remaining points for the theme:

  • "With the new theme, panel have no more colors." => this is the same as the One Dark theme. I would keep them unless you have a better suggestion?
  • "The bold font on the buttons bothers me, I feel like I'm squinting, it's nice, but I feel like it makes me more tired to read." => the rendering on Windows is not great it seems, I'll double check.
  • "Time to time on I got a the focus on the canvas" => I can't reproduce even by calling focus() on HTML elements. I'll double check on Windows too.

4ian avatar Jun 06 '22 12:06 4ian

  • "With the new theme, panel have no more colors." => this is the same as the One Dark theme. I would keep them unless you have a better suggestion?

Ok go without color, not a big deal, just a new habit to have.

  • "The bold font on the buttons bothers me, I feel like I'm squinting, it's nice, but I feel like it makes me more tired to read." => the rendering on Windows is not great it seems, I'll double check.

This may be because in dark mode, the bold white font may create a halo effect on the screen, which may disturb people & me.

  • "Time to time on I got a the focus on the canvas" => I can't reproduce even by calling focus() on HTML elements. I'll double check on Windows too.

This happened a lot of times when I go back and forth between two apps, and also by pressing tab in GD5.

Bouh avatar Jun 06 '22 19:06 Bouh

  • [x] Horizontal separators are smaller than the vertical ones and are harder to aim. image

Bouh avatar Jun 07 '22 20:06 Bouh

  • [x] Function Configuration panel is cropped image

  • [x] I wonder if the arrow to expand the JSevent should be part of the event theme and not from the Monaco theme? image

Bouh avatar Jun 07 '22 22:06 Bouh

The final points you've raised:

Horizontal separators are smaller than the vertical ones and are harder to aim. Function Configuration panel is cropped arrow to expand the JSevent should be part of the event theme and not from the Monaco theme

are present on all themes, not just the latest one, so we'll probably fix them as separate issues

ClementPasteau avatar Jun 08 '22 12:06 ClementPasteau

  • [x] In yes/no toggles, there is an inconsistency on the outline of buttons: image image

fannieyan avatar Jun 09 '22 13:06 fannieyan

Yep, I think we "hacked" a toggle but that should be built using something else than buttons.

4ian avatar Jun 09 '22 14:06 4ian

"Time to time on I got a the focus on the canvas" => I can't reproduce even by calling focus() on HTML elements. I'll double check on Windows too.

See in this GIF where is enabled the focus on the desktop app on Windows. outline

(This is the 5.0.135 compiled earlier last week by Clement.) I'll use the new 5.0.136 now

Bouh avatar Jun 10 '22 07:06 Bouh

  • In order to drop at the same level as an Event Group, you have to drop below the event group (as it contains other events, you technically cannot drop just below it, even if it is the only event)

@ClementPasteau thanks for taking the time to explain this and provide videos. I came back to this thread to vent my frustrations but after reading your post a few times I am able to accomplish my task.

Perhaps I am more affected by this because the old behavior was very intuitive for these types of changes. ("Want to change indentation? Just drag left or right!"). If we ever come back to this feature, I'd love to get some of that back.

tristanbob avatar Jun 11 '22 02:06 tristanbob

  • [ ] In the extension editor, the "Condition" field is a static size, instead of being proportional (like the main event sheet).

https://user-images.githubusercontent.com/8879811/173199988-a7854a44-d686-4f48-93e3-01dad46b45a0.mp4

tristanbob avatar Jun 11 '22 18:06 tristanbob

  • [x] In yes/no toggles, there is an inconsistency on the outline of buttons:
image image

My 2 ct for better toggles:

image

Bouh avatar Jun 12 '22 15:06 Bouh