GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Add string selector to "Change input type" for text input object

Open Elairyx7301 opened this issue 2 years ago • 2 comments

What's the difference between .useStandardParameters() and .addParameter()? Is that change ok like this?

Elairyx7301 avatar Apr 03 '22 08:04 Elairyx7301

Also, is it normal that all my commits are shown above?

image

Can I only select the relevant commits or is it just how it is? 🤔

Elairyx7301 avatar Apr 03 '22 08:04 Elairyx7301

Can I only select the relevant commits or is it just how it is? 🤔

Not a big deal here, but you should always go to the master branch, pull the latest changes, then create a new branch and start your changes here (and then open a PR thanks to this branch).

What's the difference between .useStandardParameters() and .addParameter()? Is that change ok like this?

Unfortunately that won't work like this, because useStandardParameters is not handling the second parameter. useStandardParameters is a special function that internally calls multiple times addParameter to add, well, some conventional parameters according to the type being passed.

We could add support for this second parameter, but this needs to be done carefully I think in the C++ codebase.

4ian avatar Apr 05 '22 16:04 4ian