GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Object images do not update as they should.

Open willianholtz opened this issue 3 years ago • 6 comments

I've known about this problem since old builds, and to this day I haven't seen a resolution to the problem. This is a little frustrating, as sometimes a minimal thing that has been updated in the image is not loaded.

Video: https://user-images.githubusercontent.com/23488207/150971403-3d16c1bc-4219-4465-abe4-c303458e0baf.mp4

To reproduce: Just add an image, and then edit, or do like me, just overwrite this image with another using the same name.

Possible solution: Check the integrity of the file, using some kind of check (e.g. md5 or whatever).

GDevelop 126 (Windows and Linux)

willianholtz avatar Jan 25 '22 11:01 willianholtz

I believe the engine is currently designed to not care about changes that occur in the folder unless the resources cache is manually updated. (Exiting the engine entirely and reloading, or manually selecting a new resource for the object)

However, I think this PR may change some of that behavior. https://github.com/4ian/GDevelop/pull/3517

Silver-Streak avatar Jan 25 '22 12:01 Silver-Streak

I saw this PR, but I don't know if it addresses this problem. Sorry for my ignorance on the subject, but I believe it is something that GD should have been doing for a long time.

willianholtz avatar Jan 25 '22 12:01 willianholtz

I don't disagree with you, I'm just not 100% sure that it is viewed as an issue as I believe it is not designed to view the folder as a source of truth once the project is loaded.

I linked the PR as it may be related and hope one of the contributors or devs can confirm if it would resolve this or if there is an intent to change this (or not)

Silver-Streak avatar Jan 25 '22 13:01 Silver-Streak

This is indeed the underlying issue as #3388, though the fix is a bit more involved here as it means we should observe changes in the filesystem.

4ian avatar Jan 25 '22 13:01 4ian

This is indeed the underlying issue as #3388, though the fix is a bit more involved here as it means we should observe changes in the filesystem.

Glad that I wasn't entirely off base on them being related.

I saw in the PR there is concerns about performance issues if it refreshes every tab. I have some thoughts on this but I'll post in the PR.

Silver-Streak avatar Jan 25 '22 14:01 Silver-Streak

Hello, is there any update on this matter? Any ideas that can improve the update of modified images?

willianholtz avatar Sep 07 '22 13:09 willianholtz

Solved by #5631.

AlexandreSi avatar Oct 12 '23 14:10 AlexandreSi