GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Yarn inline variables displayed as text

Open PascalLadalle opened this issue 4 years ago • 10 comments

Inline variables are in yarn reference manual but I haven't seen them in our wiki and in the example, and they don't seem to work. image image image As usual, I don't know if this is from GDevelop or Yarn itself 😅

PascalLadalle avatar Jan 05 '21 21:01 PascalLadalle

Its yarn. This syntax is not supported by bondagejs yet. Its something that needs to be implemented in bondagejs. There is already a ticket for it there on the bondagejs github tracker

On Tue, 5 Jan 2021, 23:57 PascalLadalle, [email protected] wrote:

Inline variables are in yarn reference manual but I haven't seen them in our wiki and in the example, and they don't seem to work. [image: image] https://user-images.githubusercontent.com/25978830/103703852-981bf080-4fa8-11eb-8523-0e6c7a84f403.png [image: image] https://user-images.githubusercontent.com/25978830/103703933-ba157300-4fa8-11eb-86be-583c63284a43.png [image: image] https://user-images.githubusercontent.com/25978830/103703992-d1546080-4fa8-11eb-8603-20952152341d.png As usual, I don't know if this is from GDevelop or Yarn itself 😅

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/2184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVPFUF6GD7CFJWCJCMTSYODNNANCNFSM4VWOPQLQ .

blurymind avatar Jan 05 '21 22:01 blurymind

BTW we talked about this before. I am getting a big dejavu right now :) put a bounty on this feature if you want it so much. Maybe someone on the bondagejs tracker will pick it up.

I swear this was brought up on gdevelop before

On Wed, 6 Jan 2021, 00:29 Todor Imreorov, [email protected] wrote:

Its yarn. This syntax is not supported by bondagejs yet. Its something that needs to be implemented in bondagejs. There is already a ticket for it there on the bondagejs github tracker

On Tue, 5 Jan 2021, 23:57 PascalLadalle, [email protected] wrote:

Inline variables are in yarn reference manual but I haven't seen them in our wiki and in the example, and they don't seem to work. [image: image] https://user-images.githubusercontent.com/25978830/103703852-981bf080-4fa8-11eb-8523-0e6c7a84f403.png [image: image] https://user-images.githubusercontent.com/25978830/103703933-ba157300-4fa8-11eb-86be-583c63284a43.png [image: image] https://user-images.githubusercontent.com/25978830/103703992-d1546080-4fa8-11eb-8603-20952152341d.png As usual, I don't know if this is from GDevelop or Yarn itself 😅

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/2184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVPFUF6GD7CFJWCJCMTSYODNNANCNFSM4VWOPQLQ .

blurymind avatar Jan 05 '21 22:01 blurymind

Thanks. Last time was about shortcuts. :)

PascalLadalle avatar Jan 05 '21 22:01 PascalLadalle

To be fair, it has also been requested multiple times for yarn editor, which is what gdevelop is also using as an external editor, so it might be why i am getting the deja vu.

The new version of yarn editor has playtesting that uses bondagejs and people have started requesting this same feature on their tracker too.

https://github.com/YarnSpinnerTool/YarnEditor/issues/220

blurymind avatar Jan 06 '21 15:01 blurymind

I figured out that alforno's bondage.js fork implement inline variables but the recent changes broke whatever GDevelop does with commands. I created a fork a few commits back that avoids this issue.

replacing bondage.min.js in %LOCALAPPDATA%\Programs\gdevelop\resources\GDJS\Runtime\Extensions\DialogueTree\bondage.js\dist\ is enough to get it working

MechanicalPen avatar Sep 19 '21 05:09 MechanicalPen

I really wish we had this in the master branch of bondagejs instead of forks.

The main issue is the yarnspinners syntax for this is still slightly different

On Sun, 19 Sep 2021, 08:48 MechanicalPen, @.***> wrote:

I figured out that alforno's bondage.js fork implement inline variables but the recent changes broke whatever GDevelop does with commands. I created a fork a few commits back that avoids this issue. https://github.com/MechanicalPen/bondage.js/tree/GDevelop

replacing bondage.min.js in %LOCALAPPDATA%\Programs\gdevelop\resources\GDJS\Runtime\Extensions\DialogueTree\bondage.js\dist
is enough to get it working

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/4ian/GDevelop/issues/2184#issuecomment-922419324, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRWVJBRYNIWSK4XC65EXDUCV2UBANCNFSM4VWOPQLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

blurymind avatar Sep 19 '21 06:09 blurymind

Hi @blurymind, @mnbroatch and @alforno, would it be possible to know how stable is https://github.com/hylyh/bondage.js/tree/2.0? Is there any known backward compatibility issues? I consider trying upgrading to it to solve for example the ability to include inline variables in dialogues.

4ian avatar Jan 09 '23 21:01 4ian

If switching to Yarn 2.0 support is desired https://github.com/mnbroatch/yarn-bound may be preferred due to active development and a slightly nicer API.

MechanicalPen avatar Jan 09 '23 22:01 MechanicalPen

Thanks for the comment :) Yarn-bound looks nice, though it's still based on bondage.js so it's now two dependencies to maintain including bondage.js. So I still wonder if the 2.0 version of bondage.js is by any chance stable and ready for production usage?

4ian avatar Jan 10 '23 08:01 4ian

I want this, as it would be useful for things like custom player names.

Pyroqua avatar Aug 13 '24 22:08 Pyroqua