kubeletmein icon indicating copy to clipboard operation
kubeletmein copied to clipboard

Add support for autodetecting EKS when IMDSv2 is in use

Open rileydakota opened this issue 2 years ago • 1 comments

The current implementation of autodetect will only successfully autodetect EKS when using version one of the Instance Metadata Service. This pull request adds the ability for autodetect to work correctly when IMDSv2 is in use, which is default for EKS Managed Nodes, and encouraged by defaults in cfn templates for self managed nodes.

Luckily - the AWS SDK for Go appears to seamlessly handle this (which I found out by manually specifying the provider. So it appears only the autodetect functionality needed to change.

Lastly - I am newish to Go, so please let me know if you would like any changes/adjustments to the code. I tried my best to honor the original pattern :)

Screen Shot 2022-06-12 at 1 12 04 PM

https://aws.amazon.com/about-aws/whats-new/2020/08/amazon-eks-supports-ec2-instance-metadata-service-v2/ https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html#instance-metadata-v2-how-it-works

rileydakota avatar Jun 12 '22 17:06 rileydakota

Thank you so much for this. I will review shortly.

marcwickenden avatar Jun 13 '22 16:06 marcwickenden