nuqs icon indicating copy to clipboard operation
nuqs copied to clipboard

Add a size checker

Open franky47 opened this issue 4 months ago • 8 comments

The build process for the nuqs package generates a size.json file (from size-limit).

On Pull Requests, we could:

  1. Checkout + setup + install deps + build on the target branch (should be next but could be otherwise), then save that packages/nuqs/size.json as a baseline
  2. Checkout + setup + install deps + build on the PR HEAD
  3. Do a size comparison on the changes
  4. If any, write a comment on the PR indicating the size changes (up or down, in bytes and %).
  5. When more commits are pushed, run the size comparison again.

franky47 avatar Aug 15 '25 14:08 franky47

Hi! 👋 I'd be happy to work on this issue. I’m planning to use size-limit-action to compare the bundle sizes and automatically leave a comment on the PR with the changes 😄

miinhho avatar Aug 26 '25 08:08 miinhho

Thanks!

Size limit is already installed in packaged/nuqs, so feel free to suggest a new workflow file that runs this action (following the example workflows we already have for PRs, like pkg.pr.new).

If possible, PRs that do not touch the nuqs package (eg: docs updates) should not generate a comment, to avoid noise. Or maybe skip the comment if the result is that there was no change altogether.

franky47 avatar Aug 26 '25 08:08 franky47

hello i would like to work on this issue if possible

ayesigaisaac avatar Sep 19 '25 05:09 ayesigaisaac

@ayesigaisaac thanks! Check out the discussion in #1095, the stock size-limit action had some limitations that could probably benefit from a contribution there before we can use it here.

Also relevant: #1135.

franky47 avatar Sep 19 '25 05:09 franky47

ok let first see the discussion ,,,, also can yuio share yor community ,,, for me to join

On Fri, Sep 19, 2025 at 8:19 AM François Best @.***> wrote:

franky47 left a comment (47ng/nuqs#1071) https://github.com/47ng/nuqs/issues/1071#issuecomment-3310617914

@ayesigaisaac https://github.com/ayesigaisaac thanks! Check out the discussion in #1095 https://github.com/47ng/nuqs/pull/1095, the stock size-limit action had some limitations that could probably benefit from a contribution there before we can use it here.

— Reply to this email directly, view it on GitHub https://github.com/47ng/nuqs/issues/1071#issuecomment-3310617914, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLPLHYMQYQNCRWKBDQXLVT33TOG4ZAVCNFSM6AAAAACD7UBE6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJQGYYTOOJRGQ . You are receiving this because you were mentioned.Message ID: @.***>

ayesigaisaac avatar Sep 19 '25 05:09 ayesigaisaac

I don't have a Discord if that's what you mean, everything is public here on GitHub (issues, discussions & PRs).

franky47 avatar Sep 19 '25 05:09 franky47

Ok I get you …. Let me first work on this issue then I will get to you back

On Fri, 19 Sep 2025 at 08:33, François Best @.***> wrote:

franky47 left a comment (47ng/nuqs#1071) https://github.com/47ng/nuqs/issues/1071#issuecomment-3310660006

I don't have a Discord if that's what you mean, everything is public here on GitHub (issues, discussions & PRs).

— Reply to this email directly, view it on GitHub https://github.com/47ng/nuqs/issues/1071#issuecomment-3310660006, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLPLHYJRYGAAHPYHEHZZNKL3TOIRVAVCNFSM6AAAAACD7UBE6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJQGY3DAMBQGY . You are receiving this because you were mentioned.Message ID: @.***>

ayesigaisaac avatar Sep 19 '25 05:09 ayesigaisaac

Hi @franky47 I want to work on it ... If this issue is open

Sukuna0007Abhi avatar Oct 09 '25 03:10 Sukuna0007Abhi