memeid icon indicating copy to clipboard operation
memeid copied to clipboard

Add new UUID formats from https://datatracker.ietf.org/doc/html/draft-peabody-dispatch-new-uuid-format-04

Open crispywalrus opened this issue 2 years ago • 2 comments

The new versions of UUIDs (version 6,7, and 8) are defined in https://datatracker.ietf.org/doc/html/draft-peabody-dispatch-new-uuid-format-04 This PR currently only supports version 7 as it's currently at most immediate need to me.

crispywalrus avatar Mar 21 '23 15:03 crispywalrus

Codecov Report

Merging #662 (3159bd3) into main (6beb716) will decrease coverage by 16.80%. The diff coverage is 50.00%.

:exclamation: Current head 3159bd3 differs from pull request most recent head 586e553. Consider uploading reports for the commit 586e553 to get more accurate results

@@             Coverage Diff             @@
##             main     #662       +/-   ##
===========================================
- Coverage   95.26%   78.46%   -16.80%     
===========================================
  Files          18       18               
  Lines         190      209       +19     
  Branches        7        4        -3     
===========================================
- Hits          181      164       -17     
- Misses          9       45       +36     
Impacted Files Coverage Δ
...cala/memeid4s/scalacheck/arbitrary/instances.scala 39.58% <25.00%> (-46.14%) :arrow_down:
...odules/memeid4s/src/main/scala/memeid4s/UUID.scala 74.46% <100.00%> (-25.54%) :arrow_down:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 27 '23 09:03 codecov[bot]

Thanks for your contribution! Based on the reports 1 and 2 we have decreased the test coverage. Can we include some cases for those parts?

Screenshot 2023-03-28 at 09 42 25

fedefernandez avatar Mar 28 '23 07:03 fedefernandez