pixelate.js icon indicating copy to clipboard operation
pixelate.js copied to clipboard

Various bugfix (arguments, transparent images)

Open lrq3000 opened this issue 7 years ago • 3 comments

This PR fixes various issues:

  • arguments not being accounted (ie, cannot set value parameter).
  • the pixelation of transparent images (leaving an icon in the top left corner + becoming more and more blurry if you hover in/out multiple times, because it got redrawn on the same canvas without clearing over and over again).

This also adds code comments and update the readme and add a license to be detected by Github.

lrq3000 avatar Mar 13 '18 16:03 lrq3000

This is going to be a real pain (sorry), but i just bumped the version and released a cleanup to master.

Could you have a go at rebasing your branch onto it?

After rebasing, could you then run npm run build to do any linting and re-generate the minified file using the new config?

p.s. it'll give you quite a few conflicts during rebase, again sorry for that but this really needed cleaning up.

if you need any help, give me a shout and ill be around.

43081j avatar Mar 13 '18 21:03 43081j

Haha what a coincidence! I did not expect this repo to be updated since the last was 4 years ago!

It doesn't seem like there are that many changes, I will try to have a look if I get some time :-)

However note that my changes were made only to the standalone script, not the jquery one, so maybe these changes will have to be copied over there too (but I don't know enough about jquery to do that myself).

lrq3000 avatar Mar 13 '18 22:03 lrq3000

no coincidence 🙈 saw your PR, then saw my code and couldn't resist cleaning up what past-james wrote :p

so i am responsible for the horrid rebase you may have to do, but ill be here to help if needed 😶

dont worry about jquery, its the same file, it basically checks if jquery is defined (in a silly way, which we should probably change) and adds its self as an extension method.

43081j avatar Mar 13 '18 22:03 43081j