matterbridge icon indicating copy to clipboard operation
matterbridge copied to clipboard

irc: do not bridge CTCP commands other than ACTION

Open patrickxia opened this issue 1 year ago • 1 comments

CTCP commands other than ACTION are designed for client-to-client interaction on IRC networks. Drop such messages when we receive them.

Also get rid of a "CTCP_ACTION" handler in the handler registration. The registration

  1. can't do anything (if anything, we wanted the string constant girc.CTCP_ACTION, which is "ACTION")
  2. doesn't do anything in this context, because CTCP handlers are registered separately: https://github.com/lrstanley/girc/blob/f47717952bf9258e02eac14f1b9723bcf084e618/ctcp.go#L205

The PRIVMSG handler already listens to all CTCPs.

Thanks to @lexande for the bug report (found on a live instance).

patrickxia avatar Oct 23 '23 00:10 patrickxia

Code Climate has analyzed commit b862dc34 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Oct 23 '23 00:10 codeclimate[bot]

Thanks 👍

42wim avatar May 23 '24 22:05 42wim