matterbridge icon indicating copy to clipboard operation
matterbridge copied to clipboard

Optionally suppress URL embeds for Discord

Open Kufat opened this issue 2 years ago • 3 comments

Kufat avatar Sep 05 '22 22:09 Kufat

Code Climate has analyzed commit b15bd95a and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Sep 05 '22 22:09 codeclimate[bot]

So I've been thinking about this, and this seems like a tengo script can also solve. My stance on adding new options to matterbridge is that if it can be done with a tengo script, it should be done that way.

Have you considered this as an option and it didn't work ? or maybe you didn't know about the scripting ? More info on https://github.com/42wim/matterbridge/wiki/Tengo

42wim avatar Sep 06 '22 22:09 42wim

I wasn't aware of the Tengo scripting feature, no.

It looks like Tengo scripts are global rather than per-gateway and don't have any access to the config, which wouldn't work for the use case needed on my network. (I'm sure I could bodge together something with various channel names and the desired behavior for each hardcoded, but that'd be inelegant.)

Kufat avatar Sep 07 '22 00:09 Kufat

@Kufat sorry for the late reply, you can match on the gateway in the tengo scripts, I think it should work? Wrt access to the config, for this change you also need access to the config to enable it? It's the same as adding a script? or am I missing something ?

42wim avatar Nov 26 '22 23:11 42wim

Code Climate has analyzed commit f3f8b841 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Nov 26 '22 23:11 codeclimate[bot]