matterbridge icon indicating copy to clipboard operation
matterbridge copied to clipboard

Joins and parts are send as nickname "system" which is a valid IRC nickname

Open Mikaela opened this issue 4 years ago • 1 comments

Environment

Version: 1.21.0 cf13fff7

Operating system:Debian GNU/Linux 10 (buster)

Please describe the expected behavior.

I expect that Matterbridge either uses it's own nickname or a nickname that is invalid and cannot collision (while this may be problematic with RELAYMSG).

Please describe the actual behavior.

Matterbridge claims that the parting and joining come from user "system" and in case there is an actual user with a nickname "system", it's not possible to distinguish whether messages come from Matterbridge or a spoofing user.

2021-030 15:26:05 UTC <system/IRC-Etro> Mikaela parts
2021-030 15:26:10 UTC <system/IRC-Etro> Mikaela joins

Any steps to reproduce the behavior?

Enable ShowJoinPart=true and NoSendJoinPart=false and in the paste above even UseRelayMsg=true

Please add your configuration file

Please request it separately if it's really necesary, I cannot go through it right now.

Additional considerations

  • I think using the bot nickname is the best option as that is surely free and not overlapping with another user.
  • Using invalid nickname may break with RELAYMSG https://github.com/oragono/oragono/issues/1441#issuecomment-753297978
  • Freenode has a registered nickname system

Mikaela avatar Jan 30 '21 15:01 Mikaela

Perhaps as a workaround just make the "system" part configurable?

mrdudz avatar May 30 '21 11:05 mrdudz