stud42
stud42 copied to clipboard
feat: integrate lyon campus
Special issue : Campus integration
Integrate the campus of lyon on s42
🎁 If you come from https://github.com/42atomys/stud42/labels/good%20first%20issue or https://github.com/42atomys/stud42/labels/help%20wanted : How to add a campus on s42
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Hi, just here to say that Iḿ willing to do the job. i'll go read the process for contributing and work on it in my spare time
Hi @gd-harco, noted !
We currently have a lot of issues with devcontainers.. so don't be afraid to ping me to test / validate your contribution
Hi @42atomys, sorry to bother you. The map is created, but I couldn't commit it. I'm getting a weird error message that I guess is coming from the integrated linter. Is it related to the dev container issue you wee mentioning earlier ? Here is the error message I get when trying "git commit" while inside the dev container
file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/lib/cli.js:132
throw err;
^
Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import '/usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional' is not supported resolving ES modules imported from /usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js
Did you mean to import "/usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional/lib/index.js"?
at finalizeResolution (node:internal/modules/esm/resolve:259:11)
at moduleResolve (node:internal/modules/esm/resolve:933:10)
at defaultResolve (node:internal/modules/esm/resolve:1169:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:542:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)
at ModuleLoader.import (node:internal/modules/esm/loader:472:34)
at defaultImportModuleDynamicallyForModule (node:internal/modules/esm/utils:214:31)
at importModuleDynamicallyCallback (node:internal/modules/esm/utils:253:12)
at dynamicImport (file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:10:88) {
code: 'ERR_UNSUPPORTED_DIR_IMPORT',
url: 'file:///usr/local/share/nvm/versions/node/v20.18.0/lib/node_modules/@commitlint/config-conventional'
}
Node.js v20.18.0
Hi @gd-harco, we have an issue with dev container :( And I don't have take time to fix it shame on me ! (#614)
You can commit the map open a PR, and I do the rest for you! Don't worry if error or linter issue, I will check and fix it as you can't do that.
That not your fault, the devcontainer just stop work 3 months ago for new contributor
It appears that I can't link the PR to the issue, it's number #640.