react-code-input icon indicating copy to clipboard operation
react-code-input copied to clipboard

fix: #75 - moved react and react-dom to devDependency

Open gbhasha opened this issue 5 years ago • 4 comments

and running 'npm audit fix' updated the other npm dependencies to fix the vulnerabilities.

This PR fixes https://github.com/40818419/react-code-input/issues/75

gbhasha avatar Feb 14 '20 18:02 gbhasha

Codecov Report

Merging #91 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           2        2           
  Lines         142      142           
  Branches       39       39           
=======================================
  Hits          137      137           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3491874...834094e. Read the comment docs.

codecov[bot] avatar Feb 14 '20 18:02 codecov[bot]

@40818419 can you please look into this pull request? faster response is much appreciated...

gbhasha avatar Feb 16 '20 05:02 gbhasha

Why in dev-dependencies, they must be in the peer dependencies.

sirajalam049 avatar Mar 21 '20 22:03 sirajalam049

should put them in both dev and peer dependencies so consumers will be aware.

andrewl913 avatar Mar 23 '20 13:03 andrewl913