react-code-input icon indicating copy to clipboard operation
react-code-input copied to clipboard

Fix #60 - Fix autofocus attribute and update default value

Open chris-verclytte opened this issue 6 years ago • 3 comments

Fixes issue #60 about incorrect autofocus behavior. Note for the Storybook: autofocus prop effect will be only visible on page refresh. This is expected HTML behavior that only sets autofocus for HTML elements displayed in the page, not ones added by Javascript.

chris-verclytte avatar Oct 01 '18 10:10 chris-verclytte

Codecov Report

Merging #61 into master will decrease coverage by 0.64%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   95.68%   95.03%   -0.65%     
==========================================
  Files           2        2              
  Lines         139      141       +2     
  Branches       38       38              
==========================================
+ Hits          133      134       +1     
- Misses          6        7       +1
Impacted Files Coverage Δ
src/ReactCodeInput.js 94.89% <66.66%> (-0.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01e91ea...06a75b3. Read the comment docs.

codecov[bot] avatar Oct 08 '18 09:10 codecov[bot]

could you please fix tests? thanx!

40818419 avatar Oct 08 '18 09:10 40818419

Hello Konstantin,

I am not very accustomed with JEST test runner, but it seemed to me that it was just JEST snapshots that were failing, isn't it ? Then I searched the repo for snapshots but did not find it so I don't see very well what I am intended to do to fix it. If you can drive me on this to get it quickly fixed, it would be great. Anyway, as soon as I get some time I will deep dive in JEST and fix this.

chris-verclytte avatar Oct 08 '18 09:10 chris-verclytte