Marco Trevisan
Marco Trevisan
> So, I thought about defining a `XDP_APP_INFO_KIND_TEST` app that somewhat works, but requires further tests changes. So, the paradigm to make things more testable is in #904, so once...
For sure GNOME has `org.gnome.desktop.interface.a11y`'s `high-contrast`, not sure if KDE has something similar too.
Once you've applied the suggestions, please, squash all the commits and write a commit explaining the rationale for this clearer.
@jhenstridge can you maybe check this?
@matthiasclasen wdyt about this? At the current time I decided to do an api-break on libportal too, otherwise it could be exposed as an another signal, but it looked overkill...
I wanted to add a test for checking on the old interface too, but to use libportal there too, we'd need to make a way to override the proto version,...
This would probably the involvement of a system service to manage `/etc/security` whose the sole desktop-portal has access.
Looks good but you also need to update this call to `xdp_dbus_email_set_version (XDP_DBUS_EMAIL (email), 4);`
LGTM, fwiw.
We could change a bit the way gnome-shell computes the parent app, but so far we're using this strategy: https://gitlab.gnome.org/GNOME/mutter/-/blob/main/src/core/window.c#L838-886