zync icon indicating copy to clipboard operation
zync copied to clipboard

Published 20 hours ago • verified publisher icon 3scale

Added support for falling back to native ingress if not on Openshift

Open shannon opened this issue 4 years ago • 3 comments

This PR adds support for falling back to native kubernetes ingress objects if not on openshift. It determines this based on whether the 'route.openshift.io/v1' api is present.

I'm not very proficient in Ruby so please review carefully.

shannon avatar Oct 13 '20 19:10 shannon

Looks reasonable on quick look. Are you still interested to move this forward?

akostadinov avatar May 10 '22 10:05 akostadinov

@akostadinov Yea I think so. This would be helpful to be able to provide a fully automated certificate configuration using CertManager.

shannon avatar May 10 '22 19:05 shannon

@akostadinov one thing I am noticing as I test this in my new environment is that the Kubernetes Nginx Ingress controller now requires a ingress class. Before it would just chose the default. See here. This wasn't required at the time I originally created this PR. So I think we should probably have an environment variable to specify the ingress class. WDYT?

shannon avatar May 30 '22 21:05 shannon