porta icon indicating copy to clipboard operation
porta copied to clipboard

Published 20 hours ago • verified publisher icon 3scale

Remove duplicated Quick start images

Open lvillen opened this issue 11 months ago • 3 comments

What this PR does / why we need it:

Remove duplicated Quick start images that could potentially be causing an issue with assets handling.

lvillen avatar Mar 20 '24 10:03 lvillen

What's the issue and how removing these images help to solve it?

jlledom avatar Mar 20 '24 13:03 jlledom

@jlledom actually this duplicated images is not the cause of the problem, but they're duplicated anyway and we should remove them. Regarding the problem, I'm working on a fix so, if it works, I'll rewrite the PR according to that.

lvillen avatar Mar 20 '24 14:03 lvillen

Why do we need to copy the images to pack? Isn't it better to keep them where they are?

akostadinov avatar Mar 20 '24 18:03 akostadinov

This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Apr 22 '24 03:04 github-actions[bot]

What's the problem? How can I reproduce it and check if it's fixed?

jlledom avatar May 07 '24 12:05 jlledom

What's the problem? How can I reproduce it and check if it's fixed?

The images are not shown in quickstarts (those that have images) in production mode:

image

image

mayorova avatar May 07 '24 12:05 mayorova

Forgot to mention: I tried this branch locally and the error is fixed for me.

jlledom avatar May 09 '24 14:05 jlledom