porta icon indicating copy to clipboard operation
porta copied to clipboard

🦋⚛️ Settings SSO Integrations to Patternfly 4

Open josemigallas opened this issue 11 months ago • 4 comments

I think we should used the word enforced rather than enabled for SSO. Because as long as you publish an SSO proivder, SSO is already enabled and can be used to login. The old enforce checkbox removed all other auth methos to ensure only SSO can be used to login, but it doesn't enable or disable SSO.

I agree with this. enable / disable in this context does not seem accurate to me.

Maybe, to suggest an alternative, "enforce SSO" could be worded as "disable username-password login", and "unenforce SSO" could be "enable username-password login" :grimacing:

mayorova avatar Mar 13 '24 13:03 mayorova

Hmm, something doesn't work right for me now... I have a published SSO, and I'm logged in through SSO, but the switch is disabled still...

I haven't found any (related) errors, did you make sure the integration was recently tested before trying to enforcing SSO?

josemigallas avatar Mar 18 '24 14:03 josemigallas

Hmm, something doesn't work right for me now... I have a published SSO, and I'm logged in through SSO, but the switch is disabled still...

I tried everything locally and I don't see that problem. Maybe you tested the SSO integration more than one hour ago?

jlledom avatar Mar 20 '24 10:03 jlledom

@jlledom @josemigallas I did 100% have a freshly tested integration. But since I tested there were some more commits, so I will retest of course.

mayorova avatar Mar 20 '24 10:03 mayorova