APIcast icon indicating copy to clipboard operation
APIcast copied to clipboard

Service ids should be strings, not integers

Open unleashed opened this issue 7 years ago • 1 comments

The schema for importing data states that service ids are integers, but they are opaque strings for all intents and purposes within Apicast, and that is bad because we end up converting them everywhere.

There are two ways to fix this. One is changing this line in the configuration schema so it says string instead of integer, and changing the configuration generation as needed.

The other way is using this schema but making sure it is loaded with the converted service id at initialization time.

I think this should be considered before making the schema final.

unleashed avatar Dec 01 '16 11:12 unleashed

RC1 has already been generated and released to QE, so we don't want to make changes at this point.

andrewdavidmackenzie avatar Dec 05 '16 17:12 andrewdavidmackenzie