3nprob

This function is used in these places in this repo. While it's involved in cryptographic key management I don't immediately see how this can become an actual security issue. https://github.com/matrix-org/matrix-js-sdk/blob/9eb72908a73fc17af3f5c78845affa3c6865cc66/src/crypto/store/memory-crypto-store.ts#L149...

@turt2live @richvdh (Since I see you as the users of this function when looking at the blame)

> hey @3nprob - thanks for the PR. Would it be possible to get a de-anonymized signoff on your PRs, or a form filled out with [[email protected]](mailto:[email protected]) (email) please? Thanks...

So we did have a brief chat just now. Unfortunately I had missed this before starting work: https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off > We accept contributions under a legally identifiable name, such as your...

> not sure I see the actual code change which matches the title here - it looks like a general refactoring rather than a bug fix? The existing code is...

For anyone wondering what the status is re the sign-off conversation above: Got put in touch with someone else from the Matrix Foundation and they came up with something that...

Rebased on `develop`

> @3nprob my PR was related to the test failure, but not due to the code being buggy, but the test making the wrong assertions Or more precisely: The bug...

Just curious; Why did e808e0ff18922030c74d5ead33d9e7fda3f8f600 become part of this PR and not opened as its own? Looks like a completely separate issue and only tangentially related through the tests. The...

@miku86 Thanks for the kind words :) > Are there currently any instances you know of? No, the project was just published this week (it's new but works quite well)...