lizmap-plugin icon indicating copy to clipboard operation
lizmap-plugin copied to clipboard

Use True boolean instead of string boolean in CFG file

Open nboisteault opened this issue 5 years ago • 5 comments

Description

Today .cfg contain "True" or "False" for boolean which we'll fix in Lizmap 4. Should we keep this way to do until Lizmap 4 ?

@rldhont @mdouchin Thoughts ?

nboisteault avatar Nov 19 '19 10:11 nboisteault

we should keep the old and bad way, until we change it for Lizmap 4

mdouchin avatar Nov 19 '19 10:11 mdouchin

Yes, we should switch one day to a proper JSON with boolean as bool.

I made a kind of hack in the multiatlas branch. If a single atlas was setup, it was generating the same CFG as before, with boolean as strings. But if it's a multi atlas, as it's a new data structure, I was at the same time using proper boolean in the new config. This doesn't break existing config with existing LWC. But yes maybe @mdouchin is right and we should postpone to Lizmap 4 this kind of change?

Gustry avatar Nov 19 '19 11:11 Gustry

Ok, so from this comment https://github.com/3liz/lizmap-plugin/pull/170#issuecomment-557162960 I will rollback the change.

Gustry avatar Nov 21 '19 16:11 Gustry

Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Thanks for being a part of the Lizmap community! 🦎

3liz-bot avatar Apr 24 '20 09:04 3liz-bot

Some cleaning as been done in e71d9b2298905fdd0c11e03b0c61a48e35b816ef and cd423b64f8629f68e0460953146c1802aa25d9d3

Gustry avatar May 05 '23 15:05 Gustry