helios icon indicating copy to clipboard operation
helios copied to clipboard

Don't print "could not find" warning for attributes defined in a scannerSettings template

Open han16nah opened this issue 3 years ago • 1 comments

When using a scannerSettings template (see Wiki - Scanner settings) to define the scanner attributes of a <leg>, warnings about missing attribute values are printed, even though they are defined in the template, e.g.:

XML Assets Loader: Could not find attribute 'pulseFreq_hz' of <scannerSettings> element in line 49
Using default value for attribute 'pulseFreq_hz' : 1000000

It seems like for the warning, it is only checked if an attribute value was defined in the <scannerSettings> tag of the leg but not if it is defined using a scannerSettings template. For the user, this leads to confusion about whether or not an attribute value is correctly set.

Task: Adapt the warning/error message, so that there only is a "Could not find, Using default value" message if no attribute value was found in either the defined scannerSettings template or directly in the scannerSettings of the leg.

han16nah avatar Apr 30 '21 10:04 han16nah

fixed with #142

han16nah avatar Jan 21 '22 08:01 han16nah