helios
helios copied to clipboard
Expose Scanner function to set beam quality to pyhelios
We should expose the getter and setter for the number of subrays (actually, beamSampleQuality) to pyhelios.
I am also wondering about the function
Scanner.setNumRays(int)
- is that not rather calculated from the beamSampleQuality? BeamQuality is something else than beamSampleQuality.
Please clarify these parameters and rename them if appropriate. Thanks!
I see that there is a numRays property here: https://github.com/3dgeo-heidelberg/helios/blob/a122d6d7e8cafa70781681e7d8f895dff9add439/src/pybinds/PyHelios.cpp#L439
However, setting the number of rays directly should not be supported. Instead, the beamSampleQuality should be set, and the number of rays calculated from that.
There is a scanner.fwfSettings.beamSampleQuality
property.
https://github.com/3dgeo-heidelberg/helios/blob/f1835c00c76cd1b81351c5347052812ede776bde/src/pybinds/PyHelios.cpp#L688-L692
Not sure, if this will also report the correct value if the beamSampleQuality
is set in the FWFSettings
of the survey XML or if it will always report the value configured for the scanner (in the scanner XML or the HELIOS++ default)