relion icon indicating copy to clipboard operation
relion copied to clipboard

Rewrite relion_star_printtable

Open biochem-fan opened this issue 6 years ago • 1 comments

I was using a bash script relion_star_printtable $1 data_fsc rlnResolution rlnFourierShellCorrelation to extract FSC from relion_image_handler —fsc output.

If I use this on postprocess.star, which does not have the rlnFourierShellCorrelation column but rlnFourierShellCorrelationCorrected, rlnFourierShellCorrelationParticleMaskFraction, rlnFourierShellCorrelationUnmaskedMaps, rlnFourierShellCorrelationMaskedMaps, rlnCorrectedFourierShellCorrelationPhaseRandomizedMaskedMaps, it DOES NOT give an error. Instead, it matches the column name incompletely and take the last one which contains the given label, in this case rlnFourierShellCorrelationMaskedMaps.

This is dangerous.

Another caveat is that it uses a hard-coded temporary file name tmp*.dat. This means if you call it from scripts in parallel, the result gets mixed up.

biochem-fan avatar Apr 24 '20 11:04 biochem-fan

Most problems are addressed in cfdec26. Nonetheless, we should rewrite this in C++ in future.

biochem-fan avatar Nov 06 '20 20:11 biochem-fan