netsumo icon indicating copy to clipboard operation
netsumo copied to clipboard

Published 20 hours ago • verified publisher icon 3EN-Cloud

nlapiSubmitRecord bug

Open AlanBranch opened this issue 6 years ago • 2 comments

In nsContext.js, the function nlapiSubmitRecord checks the recordsArray for a record sharing the same ID as the record being submitted. A check is not made against type. In NS, records of different types can share the same ID.

Expected behavior: I can submit a record with type 'customrecord_foo' and ID of 1, then submit a record of type 'customrecord_bar' with an ID of 1, and the recordsArray will have a length of 2.

AlanBranch avatar Feb 14 '19 18:02 AlanBranch

Hey @AlanBranch. This would be a good issue for you to create a PR for!

matthewwilson avatar Feb 14 '19 19:02 matthewwilson

Thanks. I tried, but didn't have access to push my branch to repo. I'll take another look at it.

Thanks again!

On Thu, Feb 14, 2019 at 12:05 PM Matthew Wilson [email protected] wrote:

Hey @AlanBranch https://github.com/AlanBranch. This would be a good issue for you to create a PR for!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/3EN-Cloud/netsumo/issues/17#issuecomment-463751276, or mute the thread https://github.com/notifications/unsubscribe-auth/ApRxFDNo85sQc5ja1EnKvuZMl0-Tlsluks5vNbNggaJpZM4a8Nmp .

AlanBranch avatar Feb 14 '19 22:02 AlanBranch