3dstreet icon indicating copy to clipboard operation
3dstreet copied to clipboard
verified publisher icon 3DStreet

svg extrude bevel uses bevelColor instead of color when bevelEnabled is false

Open kfarr opened this issue 2 years ago • 2 comments

instead svg extrude bevel should use color instead of bevelColor when bevelEnabled is false

in this example the yield teeth are white (per bevelColor) but should be red (per color) image

https://3dstreet.app/#/scenes/206e81b2-ef21-403d-98e8-e4103f152a74.json

kfarr avatar Mar 29 '24 23:03 kfarr

what if I make the attribute names like this?

  • top element color - topColor
  • main element color - color
  • src for the top element - topSrc
  • src for main - src

I think this names is more logical and more understandable. Is it too late to change now or will it take a long time to redo the attribute names in the current JSON files?

Algorush avatar Mar 30 '24 15:03 Algorush

what if I make the attribute names like this?

  • top element color - topColor
  • main element color - color
  • src for the top element - topSrc
  • src for main - src

I have created PR with that change: https://github.com/3DStreet/3dstreet/pull/505 And also I have changed attr names in yout JSON scene with svg-extruder: changed-attr.json

I hope you have only one scene with svg-extruder... If not, let me know. I'll change names there too

Algorush avatar Mar 30 '24 17:03 Algorush