3dstreet icon indicating copy to clipboard operation
3dstreet copied to clipboard

don't load unsupported segment type

Open Algorush opened this issue 1 year ago β€’ 0 comments

I suggest adding a check to aframe-streetmix-parser.js: if the segment type selected in streemix.net is not supported, don't try to load it or load the sidewalk segment instead or use the neighboring segment type? Which option is better, @kfarr ? Since an incorrectly loaded segment can affect other functions. For example, now in this scene (https://3dstreet.app/#https://streetmix.net/kfarr/3/example-street) 3DStreet does not have support for the "drainage-channel" segment and this leads to an error: image Because of this, the boundingBox of this segment element cannot be calculated. Which leads to a problem with other functions: https://github.com/3DStreet/3dstreet/pull/449#issuecomment-1913733612

Algorush avatar Jan 28 '24 22:01 Algorush