3dstreet icon indicating copy to clipboard operation
3dstreet copied to clipboard

add `wheel` component to rotate wheels of compatible assets

Open kfarr opened this issue 3 years ago β€’ 1 comments

Suggested steps:

  • [x] create a new branch that migrates the wheel component from https://glitch.com/edit/#!/wealthy-rural-larch to a new component in this file: https://github.com/3DStreet/3dstreet/blob/main/src/index.js
  • [x] migrate the demo from glitch to wheel.html or similar
  • [x] document how to prepare a model that is compatible with this component (just a few sentences)
  • [x] document how to use the component in a similar fashion to https://github.com/3DStreet/3dstreet/blob/main/README.md#a-frame-street-component-api
  • [ ] update vehicle animation logic to include the wheel component https://github.com/3DStreet/3dstreet/blob/main/animated.html (this might replace the need for wheel.html)

I can help with some of the later steps once you get the first few steps implemented on a branch

kfarr avatar Aug 03 '22 22:08 kfarr

Hi @kfarr I don't have write access to 3Dstreet. I might not be able to create new branch. Shall I create a fork instead of branch?

gnansai avatar Aug 04 '22 05:08 gnansai

https://github.com/3DStreet/3dstreet/tree/vehicle-wheel-animation

kfarr avatar Aug 19 '22 23:08 kfarr

Hi @kfarr I added documentation here https://github.com/3DStreet/3dstreet/blob/vehicle-wheel-animation/README_vehicle-wheel-animation.md

gnansai avatar Aug 20 '22 02:08 gnansai

I tried adding animation to wheels. https://github.com/3DStreet/3dstreet/blob/vehicle-wheel-animation/animated.html I added links to new vehicle assets-rig here https://github.com/3DStreet/3dstreet/blob/vehicle-wheel-animation/src/assets.js I modified here to add wheel rotation. https://github.com/3DStreet/3dstreet/blob/vehicle-wheel-animation/src/aframe-streetmix-parsers.js

gnansai avatar Aug 20 '22 02:08 gnansai

https://user-images.githubusercontent.com/25223402/185725843-f0005bb1-e5d2-43a6-a91e-aef97c48b8ce.mp4

gnansai avatar Aug 20 '22 02:08 gnansai

I have to implement the relation between speed of the vehicle and wheel rotation in this new Animation system.

gnansai avatar Aug 20 '22 02:08 gnansai

Thanks for the help on discord to merge this. There are still a few things to cleanup that I am continuing on the same branch: https://github.com/3DStreet/3dstreet/tree/vehicle-wheel-animation

  • would like to only have 1 set of assets (rigged vehicles instead of non rigged)
  • need to update assets-dist repo as well as assets.js and aframe-streetmix-parsers.js to reflect one set of vehicle assets

kfarr avatar Aug 25 '22 04:08 kfarr

Ok merged the rest of the fixes here: https://github.com/3DStreet/3dstreet/pull/195

Created separate ticket to track consolidating assets: https://github.com/3DStreet/3dstreet/issues/199

kfarr avatar Aug 25 '22 20:08 kfarr