3dstreet icon indicating copy to clipboard operation
3dstreet copied to clipboard

Modify existing dense buildings to make them less east-coast

Open kfarr opened this issue 3 years ago β€’ 8 comments

  • remove fire escapes
  • remove air conditioners and ventilation ducts from roof
  • removing air conditioners from window units

kfarr avatar May 27 '22 19:05 kfarr

Hi @kfarr Could you point me to the "existing dense buildings" on github?

gnansai avatar Jun 01 '22 03:06 gnansai

@gnansai here is the output set: https://github.com/3DStreet/3dstreet-assets/blob/main/sets/buildings/gltf-exports/buildings.glb

I think the source is here: https://github.com/3DStreet/3dstreet-assets/blob/main/models/buildings/buildings.blend

Here's a picture of the style of buildings I'm referring to: image

kfarr avatar Jun 01 '22 03:06 kfarr

Also to add to the list of things to remove: can you also delete the stylized dark red brick elements on the front faces?

These things: image

kfarr avatar Jun 01 '22 03:06 kfarr

Hi @kfarr I removed the *fire escapes *air conditioners and ventilation ducts from roof *air conditioners from window units image image image image image

gnansai avatar Jun 05 '22 05:06 gnansai

I updated the buildings glb here https://github.com/gnansai/3dstreet-assets/tree/main/sets/buildings/gltf-exports

gnansai avatar Jun 05 '22 05:06 gnansai

This is great progress! Can you also remove:

  • billboard frame
  • satellite dish
  • green slanted roof box on the roof

kfarr avatar Jun 05 '22 05:06 kfarr

Sure, I removed *billboard frame *satellite dish *green slanted roof box on the roof image image

gnansai avatar Jun 05 '22 05:06 gnansai

Thanks Gnanasai! I'd say this task is complete from a 3d model perspective and now awaits implementation

kfarr avatar Jun 06 '22 18:06 kfarr

Great, looks done to me!

On Sat, Jun 4, 2022 at 10:57 PM gnana sai reddy @.***> wrote:

Sure, I removed *billboard frame *satellite dish *green slanted roof box on the roof [image: image] https://user-images.githubusercontent.com/25223402/172037449-10443943-7327-4d25-b069-ef9624b45bd7.png [image: image] https://user-images.githubusercontent.com/25223402/172037456-b75a0d40-4027-424a-bbe4-7476833d4c14.png

β€” Reply to this email directly, view it on GitHub https://github.com/3DStreet/3dstreet/issues/180#issuecomment-1146747735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS3TIEJVX5RGQU4NKBUVDVNQ6V3ANCNFSM5XFECIOA . You are receiving this because you were mentioned.Message ID: @.***>

kfarr avatar Oct 11 '22 09:10 kfarr

The buildings are here in 3dstreet-assets-source https://github.com/3DStreet/3dstreet-assets-source/blob/main/sets/buildings/gltf-exports/buildings.glb

They should also be updated to meshopt -cc per https://github.com/3DStreet/3dstreet/issues/198

Also they should no longer use model-center component in assets.js after this change, it is no longer necessary since gnanasai has correctly centered the models: (in fact no model should use this, including suburban buildings, it is not necessary to use this component) https://github.com/3DStreet/3dstreet/blob/main/src/assets.js#L111

You may need to also adjust some of the positioning logic here: https://github.com/3DStreet/3dstreet/blob/main/src/aframe-streetmix-parsers.js#L972

kfarr avatar Dec 05 '22 23:12 kfarr

closed by #233

kfarr avatar Dec 14 '22 05:12 kfarr