Jingyang Kang

@at-wat I've resolved the conversations that I think may be resolved by follow up changes for less buzz. Feel free to reopen them if needed😊

@at-wat Thanks for your review! This is ffmpeg's documentation https://ffmpeg.org/doxygen/3.3/group__lavc__encdec.html I think we need to keep trying when received EAGAIN, but I'm not sure about EOF, I will test it...

@at-wat Sorry for the delay, I've tested and tweaked the codec config options and found that as long as the encoder is configured with constrained VBR and no B frames...

@JoeTurki Thanks for review! Sure, I will look into existing tests to see how to test this kind of things properly.

@JoeTurki I refactored the code a bit for better testability and add test cases for video stream only and video + RTX, this is ready for review again. No rush...

> Is the call to r.rtxPool.Put(b) necessary here? @arjunshajitech `handleReceivedRTXPackets` in this PR is exactly the same as the old anonymous function in `receiveForRtx`. When I'm doing the refactor I'm...

Thank you so much @arjunshajitech ! I hope this PR's refactor doesn't change any current behavior and logic, only improves testability so that reviewing is easier. Do you mind opening...

> @3DRX, do you think that it would be better to feed RTX/FEC packets to the same stream as the media packets? These streams are not separate in BindLocalStream, so...

@JoeTurki @aalekseevx have a good point here, I guess we can also mark this as a reasonable breaking change in future major version? This won’t block this PR though, it’s...

> Maybe it's time to start making a v5 milestone? and aim for jan 2026? @JoeTurki So sorry I missed this, sure we can make the milestone, there's a couple...