react-tinder-card icon indicating copy to clipboard operation
react-tinder-card copied to clipboard

fix: add explicit optional children attribute to TinderCard Props as required by React 18

Open brainsaysno opened this issue 3 years ago • 2 comments

Added explicit optional children attribute to TinderCard Props as required by React 18. See changes here. Fixes #91.

brainsaysno avatar Jun 20 '22 18:06 brainsaysno

@brainsaysno Looks good however you need to update the readme by running ts-readme generator. Just run npm run test as explained in the CONTRIBUTING.md and it will run. Then commit that change and I will merge this.

3DJakob avatar Jun 28 '22 10:06 3DJakob

@3DJakob I'm getting this error when running npm run test

❯ npm run test

> [email protected] test
> standard && ts-readme-generator --check

AssertionError [ERR_ASSERTION]: not implemented
    at getFormattedTypeName (/Users/nrusso/contributions/react-tinder-card/node_modules/ts-readme-generator/bin.js:129:3)
    at formatReactComponentProps (/Users/nrusso/contributions/react-tinder-card/node_modules/ts-readme-generator/bin.js:161:22)
    at main (/Users/nrusso/contributions/react-tinder-card/node_modules/ts-readme-generator/bin.js:356:33)

If you could point me in the right direction I can make that commit right away. I'm not very familiar with ts-readme-generator.

brainsaysno avatar Jun 28 '22 13:06 brainsaysno

@brainsaysno so sorry for the delay on this, I've fixed the error in ts-readme-generator here: https://github.com/LinusU/ts-readme-generator/pull/5

Will release that shortly and then we can upgrade here

edit: released 🎉 https://github.com/LinusU/ts-readme-generator/releases/tag/v0.7.2

LinusU avatar Aug 26 '22 09:08 LinusU

Thank you for the contribution @brainsaysno 🎉

LinusU avatar Aug 26 '22 09:08 LinusU

🙌 Yᗩᔕᔕ 💃

thinktapper avatar Aug 26 '22 10:08 thinktapper

Support for React 18 is now published as 1.5.0 🚀

LinusU avatar Aug 26 '22 10:08 LinusU