[contacts] photo not exposed

[cinghiopinghio]

dear @39aldo39,

While setting up contacts on the laptop (through Radicale-Decsync) I encountered that my contacts are exposed by radicale without picture.

At a more detailed check, it appears that radicale is exposing:

PHOTO:data:image/jpeg\;base64

instead of:

PHOTO;ENCODING=BASE64;JPEG:/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAUDBAQEAwUEBAQ
 FBQUGBwwIBwcHBw8LCwkMEQ8SEhEPERETFhwXExQaFRERGCEYGh0dHx8fExciJCIeJBweHx7/
 2wBDAQUFBQcGBw4ICA4eFBEUHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eH
...

The picture data are present in the syncthing folder of the local device [...]/contacts/colID123456/v2/xxxx-Radicale/2c:

[["resources","f580b28d-cf50-4437-a528-bf48ebc7bdfa"],"2020-06-22T16:37:04",null,"BEGIN:VCARD\r\nVERSION:4.0\r\nPRODID:ez-vcard 0.10.6\r\nUID:f580b28d-cf50-4437-a528-bf48ebc7bdfa\r\nFN:xxxx yyy \r\nN:xxx;;;\r\nTEL;TYPE=cell:+34643\r\nBDAY:198\r\nPHOTO:data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAUDBAQEAwUEBA\r\n QFBQUGBwwIBwcHBw8LCwkMEQ8SEhEPERETFhwXExQaFRERGCEYGh0dHx8fExciJCIeJBweHx7/\r\n 2wBDAQUFBQcGBw4ICA4eFBEUHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh\r\n 4b7eUYJP+y/Hyr+zX0v06faf8j5S0AGVzwAAAAAAAFK0bncRnNM/ZXUFVUZQioUKspdFNLs7N8l\r\n JdXPrRyXvC3LxrP5G/sq9F9mU3KEtv2Sa+pgDpt8hf28Ohb3tzRh+mFWUV9GafGraIjSOeG6Oq\r\n z0rFdq8zH7ieJUvAaPxmlJxzWpclbyqUfvUqceypL81vzk/BJGJ1zqGpqPNSulGVO3pr4dCD61\r\n Hxfm/88D4letVr1HUrVZ1ZvrlOTb/lngjptE17KxxCG3VRanh517a/PqAAoZAAAAAAAAAAAAAA\r\n AAAAAf/Z\r\nREV:20200622T163704Z\r\nEND:VCARD\r\n"]
[["resources","81d9a888-59d0-462b-8bf6-25585312ed04"],"2020-07-03T08:23:02",null,"BEGIN:VCARD\r\nVERSION:4.0\r\nPRODID:ez-vcard 0.10.6\r\nUID:81d9a888-59d0-462b-8bf6-25585312ed04\r\nFN:Alennes\r\nN:Darin;;;\r\nORG:DDDD\r\nEMAIL;TYPE=home:[email protected]\r\nREV:20200703T082302Z\r\nEND:VCARD\r\n"]

[39aldo39]

What app are you using with Radicale? The exposed VCard looks correct according to the spec (see the PHOTO property).

And FYI: if you edit a comment it can still be viewed. You have to delete it explicitly if desired.

[cinghiopinghio]

Yes, it looks correct except that it completely lack the base64 data, from /9j/ onward.

[cinghiopinghio]

According to the linked specs (v4.0), at the end of the line one should find a comma and the actual data that are not presented.

[cinghiopinghio]

Updates:

After updating to libdecsync v2.2.1 on my desktop machine, all contacts with:

VERSION:3.0
PRODID:ez-vcard 0.11.3

rightfully expose the photo as:

PHOTO;ENCODING=b;TYPE=jpeg:/9j/4AAQSkZJRgABAQAAAQABAAD[... all the other data here in one line]

All other entries with VERSION:4.0 and several values for PRODID fail to do so, only exposing:

PHOTO:data:image/jpeg\;base64[no data appended here]

[cinghiopinghio]

Hi, if you could point me to the right place to check, i could try to create a pull request.