Oliver Byford

Results 238 comments of Oliver Byford

> The NHS design system still has full width labels for checkboxes (but not radios) - we could reach out to them to see if it's ever come up in...

(Raised at https://github.com/nhsuk/nhsuk-frontend/issues/842)

As flagged in https://github.com/alphagov/govuk-frontend/pull/2828#discussion_r963437018, there are a few edge cases where this could be considered a breaking change. Specifically, if a user is using `getAttribute` and relying on the value...

Thanks for raising this, @RichardBradley. I'm going to transfer this issue to the govuk-frontend repo, as this relates more to the code for the component than the guidance in the...

As raised by a user on Slack, the lack of print styles means that the panel component prints with light grey text on white: ![image](https://user-images.githubusercontent.com/121939/79877291-f9347180-83e3-11ea-9e12-9bc90dbd2ff5.png) I believe this is the...

> Would you be up for me working on this as a contribution? Thanks for the offer @NickColley! We're slightly concerned that this might turn out to be quite a...

> Could someone from the Design System Team take a look at the test failure here please? I tried to fix it locally before pushing but I'm not clear on...

I think there are three things we need to decide on to unblock this: - Where in the package the new CSS and JS files live - Where we 'author'...

> I'm not impacted by the outcome, I'm just saying this to help if I can. > > 1. Removing `package/` would be good, it's difficult to avoid committing package...

It'd be good to clean up the commit history for this PR before it gets merged, please – give us a shout if you need a hand with that 🙂