31z4
add jmx agent to storm 2.4.0
Add JMX Javaagent to Dockerfile.
@jgiannuzzi mentioned it would be a great addition to make the JAR accessible from within the Docker image for exporting Storm metrics.
Hi @31z4, Can you pleas look into this PR? Adding prometheus JMX exporter into storm docker image could be useful in all storm use cases.
We are using it in storm helm charts with patching this file into docker image that we would like to avoid. You can have a look into https://github.com/G-Research/charts/pull/72 which is waiting for this PR to be merged. An example of a storm application that using the helm charts and the docker image with JMX exporter and storm metrics collected by Prometheus https://github.com/G-Research/siembol/pull/692 We can patch the file into the docker image but I believe this exporter can be useful for other storm deployments since Prometheus metrics scrapping has become standard in monitoring. Thanks, Marian
I consider JMX agent as something nice to have but not required to run Storm. Also, it is not a part of the official Storm distribution. Adding it potentially introduces new attack vector and will require additional maintenance efforts. Sorry, I'm not going to add JMX agent to the image. You might consider suggesting it to the upstream 😉
