wnhlee
wnhlee
integration test failure is not related to this PR: https://github.com/facebook/lexical/issues/6413
@StyleT > Afterthought: seems like call of the canMergeWhenEmpty shall not happen within CASE 3: At least 1 element of the array is not inline to solve issue with quote...
@GermanJablo > My only observation is that isLi is still used in one more place. If it is replaced by canMergeWhenEmpty, does any test fail? It doesn't fail. But the...
1. done it. 2. I don't have strong opinions on this either but just mentioning for agreement. If it's just about quote, more dedicated fix would be needed here. Otherwise...
@etrepum @StyleT Thank you. I added jsdoc here.
Failure of `e2e-tests / prod (macos-latest) ...` is due to #6463
It happens because `selection` is updated by clicking the text with black color when closing the dropdown: - when we select the new font color (red) on the color picker,...
So this can happen on other case as well such as font size. But in this case, it doesn't feel like a bug (at least for me). IMO, it is...
So closing dropdown by click preserving the selection could be a fix.