2sxc icon indicating copy to clipboard operation
2sxc copied to clipboard

Feature request: quickE should be disabled by default

Open ajplopez opened this issue 4 years ago • 9 comments

I'm submitting a ... [x] feature request

...about [x] edit experience / UI [x] admin experience UI

Current behavior By default, the quickE menu is enabled so content editors and admins see these buttons.

Screen Shot 2021-06-13 at 5 07 39 PM

Expected behavior I think the quickE should not appear unless me, as a developer, add it to the site to include that functionality.

Instructions to Reproduce the Problem N/A

Why change the behavior? I always hide these via CSS. I've now recently discovered that they can be disabled on the page via the template, like so:

<div @Edit.Attribute(“quick-edit-config”, new { modules = new { enable = false }})>

However, this involves editing most of the templates to include this code. I wish that the quickE buttons were disabled by default because my content editors nor I ever use them.

Alternatively, instead of making it disabled by default, another option could be a simple toggle that turns it off for the entire portal. That way it could stay enabled but then we can turn it off from one place, rather than hide it via CSS overrides or update all the razor templates.

Your environment

  • 2sxc version(s): [all]
  • Browser: [all ]
  • DNN: [all ]
  • Language: [any/all ]

Anything you would like to add I've spoken with a few other developers who use 2sxc and everyone hides them because they result in accidental clicks. This seems like a feature that should be opt-in, not opt-out.

ajplopez avatar Jun 14 '21 03:06 ajplopez

Over the last 2 years we have definitely found the QuickE stuff to be both a benefit and a hinderance. On the con side, they easily get in the way of other UI elements and often users accidentally click them, get confused when 2sxc then goes in to add-module-mode, and then leave unconfigured Content or App modules on the page (and apparently run away in fear they have broken something?).

I do feel like QuickE is more of a benefit when the page is only/mostly using the Content App's basic content types. This covers 50 to 80% of some of our small-medium projects and I would not want it undone by default since it can be pretty awesome on the right type of content page. Its also a phenomenal demo for potential new clients. :)

Another thing to consider is QuickE is mostly trying to do things the CMS already does. If it was flawlessly faster and never in the way or causing accidental module adds, that would be fine. But that is not the case.

Dnn also recently added a quick-add option to the PersonaBar's edit mode bottom bar (around v9.09?). You'll note they left it off on upgrade (you turn it on via settings globally) and it is on by default on new installs.

My suggestion for behavior changes:

  • Leave it on, as-is for Content-App modules
  • Leave it OFF by default for 2sxc app modules
  • Then make it easier to configure the behavior...

Introduce Settings/Features that allow QuickE to be configured from the top-down at a) host/instance level, b) portal/site, c) channel/section/page**, and d) module level.

Then its just a matter of what the settings do. I do not think it is a simple on/off, instead its a "mode" that could be represented by an int (allowing for more modes in the future).

  1. Always on (forced/required)
  2. Always on (settings in the View or elsewhere could turn it off)
  3. On for Content, Off for Apps << IMHO this should be the default
  4. Soft Off (settings in the View could turn it on if needed/desired)
  5. Hard off, disabled

And I definitely want to stress that the current config/settings via code is a poor choice and this needs to be in the UI as a first class citizen and seems like a perfect addition to the recent View Settings improvements!!

** I realize Dnn doesn't have channels/sections, but other CMS' do and that should be taken in to consideration or planned for. :)

jeremy-farrance avatar Jun 14 '21 05:06 jeremy-farrance

@jeremy-farrance & @ajplopez

ATM we're internally trying to architect a global settings-system which would allow all kinds of configuration to be set at multiple levels - like by the software, at system level, at site-level etc.

Once that is done, we can address this specific need. But it won't be ready till after summer.

iJungleboy avatar Jun 14 '21 07:06 iJungleboy

I will second this request with both arms raised. Disabling quickE in all templates is a drag.

enfJoao avatar Oct 05 '21 18:10 enfJoao

@eXistenZe Thanks Joao. For what it's worth, if you use this on any template on a page, it will disable quickE for the entire page.

<div @Edit.Attribute(“quick-edit-config”, new { modules = new { enable = false }})>

So the nice thing is that I just put it in my hero app which I use on every page anyway and it works. A fine solution in the meantime.

ajplopez avatar Oct 05 '21 18:10 ajplopez

Here the original request from quite a while ago. #1298

enfJoao avatar Oct 05 '21 19:10 enfJoao

Given the amazing "Settings" additions in v12+ - I think this is a great candidate for getting fixed and making everyone happy via Default, Global, Site, etc. settings. Hopefully @iJungleboy reads this, agrees, and feels its is quick, logical, and maybe even easy addition?

jeremy-farrance avatar Oct 06 '21 00:10 jeremy-farrance

This is planned somewhere down the roadmap, but it's quite complex to get the current state into the skin, so it's not a priority yet (as there is a workaround, even if not ideal).

iJungleboy avatar Oct 06 '21 09:10 iJungleboy

This is definitely an ongoing annoyance for us and now that Settings seems useful, understandable, and (possibly) mature - Any chance this can get another look and rethink? Cheers!

jeremy-farrance avatar Jul 07 '23 23:07 jeremy-farrance

This is definitely an ongoing annoyance for us and now that Settings seems useful, understandable, and (possibly) mature - Any chance this can get another look and rethink? Cheers!

This keeps coming up a lot as you can see on StackOverflow, even recently. https://stackoverflow.com/search?q=%5B2sxc%5D+quicke

Our problem today was that we wanted to turn it off on all pages, and then as needed, turn it on for a few modules (like the 2sxc Accordion App). So, we added this in the theme (header.ascx):

<div quick-edit-config='{"enable":false}' data-comment="Disable 2sxc QuickE for this page"></div>

This did what we wanted for most pages, but we thought the config was hierarchical and that in the Accordion this code would turn it back on:

<div class="app-accordion4-wrapper" @domId @Edit.Attribute("quick-edit-config", new { modules = new {  enable = true }})>

And we were surprised when it was off for the page, but NOT working in the Accordion.

jeremy-farrance avatar Dec 08 '23 19:12 jeremy-farrance