Changing only item's Status to Hidden unexpectedly shows Demo Item
I'm submitting a bug report about [x] edit experience / UI [x] admin experience UI [x] Content Types or data management
Current behavior Using any App or the Content App, add an item. Click Edit, fill it out and save so your new content is displayed. Click Edit again, change status to Hidden or Draft. Save. Log out, now the "demo" item shows publicly.
Expected behavior Following the steps above, changing a solo content item's status to Hidden or Draft should not output anything.
Minimal reproduction of the problem with instructions
Steps above.

What is the motivation / use case for changing the behavior? The demo item is there to assist editors, content managers. It doesn't make sense to show it to the public in most cases and especially in this case. The content manager's expectation is that they hid the item and nothing should be showing.
Please tell us about your environment: Win Server 2016, IIS 8+, .NET 4.7+
2sxc version(s): 10.21.0 (latest) Browser: all DNN: 9.04.04 (latest, not an RC) Language: any/all
This is a tricky one. internally the module data source substitutes a demo item if the real item isn't there. If the data is draft-only (without a published copy) then it "feels" the same way.
As of now there is a minimal help with .IsDemoItem you can make your template behave differently for demo items. There is currently no real plan to change this behaviour, because we're not really sure what the behaviour should be. like should the module disappear, should the template render an error etc. Very tricky...
I think the best plan is to simply take it from the perspective of the content manager and the website's anonymous user/visitor. Simply put, as a content manager, if I mark the item as HIDDEN, I would expect it to not appear to the public. If you then show a Demo item - an item clearly intended for the content manager/editor - then the system feels broken. Unless someone can demonstrate a logical scenario, tricky or otherwise, where it makes sense to translate Hidden or Draft in to showing a Demo item to the public (anonymous visitor), I hope you will reconsider and fix this.
This old one should be closed now since there are two solutions available (though the docs still are not helpful in arriving at either one if you are unfamiliar with 2sxc entities). https://stackoverflow.com/questions/77619702/issue-with-content-module-list-of-links-in-2sxc/77623150
thx for the clean-up :)