new TAP test map seems to hang sporadically

[mbanck]

Trying to package 2.3.0, I've noticed that the map TAP test appears to hang (i.e., taking > 1 hour); once on my local notebook for v11, and on the PGDG build server for v9.5.

I don't have time to dig into this right now, but wanted to open issue to keep track of it. Will try to look into it later on.

[PJMODOS]

It does not hang, it just sometimes takes like 5 minutes to run through.

[mbanck]

Not for me, if it hangs, it seems to hang indefinetely until the build system issues a timeout.

The last output from map seems to be (regression_output/results/map.out):

TRUNCATE  "subscriber.pong".test_target;
-- test resynchronize when multiple origin for the same table (origin indistincts sets
SELECT * FROM pglogical.alter_subscription_resynchronize_table('sub_map1', '"subscriber.pong".test_target', true);
 alter_subscription_resynchronize_table 
----------------------------------------
 t
(1 row)

SELECT pglogical.wait_for_table_sync_complete('sub_map1', '"subscriber.pong".test_target');

[mbanck]

I think what is missing is the usual SET [LOCAL] statement_timeout = '120s'; before the wait_for_table_sync_complete() calls in map - all the other regression tests have it and that leads to the usual flakiness of the pglogical tests in the PGDG buildfarm (after I've removed map from the list of tests) like this (link will not be permanent): https://pgdgbuild.dus.dg-i.net/job/pglogical-binaries/93/

I.e. then we will get failed test cases instead of hanging builds that get killed off after a timeout.