pg_stat_plans icon indicating copy to clipboard operation
pg_stat_plans copied to clipboard

Change extensions layout

Open klando opened this issue 11 years ago • 5 comments

the current inclusion of pg_find_plans into pg_stat_plans is not helpful for packaging.

What about the following layout ? ├── debian ├── Makefile ├── pg_find_plans │   └── Makefile └── pg_stat_plans └── Makefile

The top Makefile allows to builld with options like that : make PG_STAT_PLANS=1 PG_FIND_PLANS=1 # (the default) and each sub-Makefile works as usual.

Even if we don't want to keep the debian/ (and a rpm/ ?) I do prefer this layout.

OK ?

klando avatar Aug 13 '13 11:08 klando

@klando Makes sense to me - it would be nice to build/install everything in one go. I think, just for the record, that it was the correct decision to make pg_find_plans a separate module that resides in the same source control repository.

The convention I favour for pg_find_plans is that its version and dependency on pg_stat_plans should match pg_stat_plans (So right now they're all 1.0, which is good). We should stick to this.

There is only going to be an rpm/ if someone steps forward and makes the effort to work on that. It's unlikely to be me.

petergeoghegan avatar Aug 14 '13 17:08 petergeoghegan

I'll probably have a look at rpm packaging in the near future

terrorobe avatar Oct 01 '13 12:10 terrorobe

@terrorobe, do you packaging it into rpm already?

Hubbitus avatar Aug 04 '15 08:08 Hubbitus

@Hubbitus We ended up not using pg_stat_plans due to https://github.com/2ndQuadrant/pg_stat_plans/issues/39

lfittl avatar Aug 04 '15 18:08 lfittl

@terrorobe thanks.

Hubbitus avatar Aug 04 '15 20:08 Hubbitus