docker icon indicating copy to clipboard operation
docker copied to clipboard

Great image, would you consider adding support for custom modules?

Open virtuman opened this issue 8 years ago • 1 comments
trafficstars

Awesome image, thank you for sharing.

Would you consider adding support for a couple of things to this:

  1. LDAP module, similar to this one here: https://hub.docker.com/r/virtuman/docker-nginx/~/dockerfile/
  2. not sure if anyone ever uses or if anyone would benefit from this, but generally a good module: nginx_upload_progress
  3. virtual host stats: nginx-module-vts
  4. with-http_geoip_module
  5. with-http_image_filter_module
  6. with-libatomic
  7. with-http_image_filter_module
  8. possibly add an Environment variable to append to ./configure statement, ie. $ADDITIONAL_CONFIGURE_PARAMETERS

some of the modules support dynamic loading (like geoip).

here's a very good implementation of dynamic modules: https://github.com/ngineered/nginx-php-fpm/blob/master/Dockerfile combination of both of these image builders would create and ultimate nginx image

Thank you for consideration

virtuman avatar Nov 30 '16 01:11 virtuman

Thanks for your comments. I'm definitely open to suggestions about useful modules for the build, while at the same time trying not to go crazy with cruft.

The currently installed modules are only those which I find regular use for. If you would like to create pull requests for modules you find particularly useful, along with supporting arguments then I will definitely consider adding them to the Dockerfiles.

27Bslash6 avatar Jan 26 '17 01:01 27Bslash6