[4.3] Dialyzer issues

[bradfordben]

[bradfordben]

@jamesaimonetti No they are all just changes that popped up due to dialyzer. No bug fixes here. We have changed our build ci to run dialyze-hard and not dialyze-changed as it was not catching some simple errors.

But now its catching errors from other areas of the code base when we make any changes. So this is just dialyze errors that popped up.

Would you consider changing your dialyze checks to run dialyze-hard ? or is there a reason why you have not chosen to do this? We chose to run hard as without it, it missed a simple type bug and caused an issue in production for us.

[lazedo]

@bradfordben but the changes are breaking things, no ? specially the knm_numbers.

[bradfordben]

@lazedo No the changes should not be breaking. knm_numbers change is a case that dialyzer was complaining to say that as the new/4 function is only called with an atom or knm_errors:error() as Reason so the function check is not needed.