laravel-saml2 icon indicating copy to clipboard operation
laravel-saml2 copied to clipboard

Make --metadata take a JSON object

Open pixelcat opened this issue 1 year ago • 1 comments

Background:

The metadata parsing as it exists today won't honor http:// schema names, which we need in order to support multiple IdP types, and specifically Microsoft Entra ID which uses schemas instead of simple strings.

As part of our implementation we store those schema names as mappings to field names in metadata, such as the following:

| Metadata        | Array                                                                                             
|                 | (                                                                                                             
|                 |     [field_email] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress
|                 |     [field_lastName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname
|                 |     [field_uniqueId] => http://schemas.microsoft.com/identity/claims/objectidentifier 
|                 |     [field_firstName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname                     
|                 | )

Solution: Instead of mapping metadata to an array based on : as a separator, this PR allows users to specify metadata as a serialized JSON string during creation or update.

pixelcat avatar Apr 25 '24 16:04 pixelcat

Great idea and thanks for your PR @pixelcat. I'd suggest keeping backward-compatibility, either dynamically check if JSON was provided and then treat as JSON or introduce a new option like --metadata-json.

breart avatar Sep 13 '24 17:09 breart