laravel-saml2 icon indicating copy to clipboard operation
laravel-saml2 copied to clipboard

Fix sail port

Open raphaelcangucu opened this issue 2 years ago • 2 comments

Just a small fix to work behind a Laravel Sail environment.

The SAIL always start the internal PHP server at port 80, and sometimes we run the SAIL on a different port, in my case it was to have 2 envs running in my machine. One for the IDP (port 80) and other to the SP (port 8888).

So the the code was getting always the 80 port from the internal PHP Server and trying to access the IDP server intead of the SP.

To fix this, I just added a new configuration at them config file to set the port if exists with the default value getting the APP_PORT from laravel's .env file.

raphaelcangucu avatar Jun 06 '23 22:06 raphaelcangucu

Looks good! Please remove one change related to the formatting and I'll merge this.

breart avatar Nov 26 '23 10:11 breart

Hi @raphaelcangucu ,

I'm eagerly waiting for your change to be part of the package. Would you please remove the change in src/Http/Controllers/Saml2Controller.php so breart can continue?

Thank you for this fix!

Best regards

ockstadt avatar Jan 30 '24 09:01 ockstadt