laravel-saml2 icon indicating copy to clipboard operation
laravel-saml2 copied to clipboard

Q: Is config.php value NameIDFormat no longer used?

Open darynmitchell opened this issue 3 years ago • 0 comments

Q: Should NameIDFormat be removed from the config file?

Details:

Commit 7cdac6013b6ea3d544306d16c229106e8a746f28 introduced per-tenant nameID format, stored in DB and defaulting to persistent

The config file still has a value NameIDFormat

    'sp' => [

        /*
        |--------------------------------------------------------------------------
        | NameID format.
        |--------------------------------------------------------------------------
        |
        | Specifies constraints on the name identifier to be used to
        | represent the requested subject.
        |
        */

        'NameIDFormat' => 'urn:oasis:names:tc:SAML:2.0:nameid-format:persistent',

But I think that value is now ignored. Is that correct?

If so I can open a PR to remove that from config.php

darynmitchell avatar Dec 07 '22 10:12 darynmitchell