M. Casqueira

Results 79 comments of M. Casqueira

Hey, I might be misunderstanding but if you merged PR 2 to master then you cannot merge PR 1 unless you update it with master. After you update PR 1...

Are you using the "Rebase and Merge" option ? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#rebase-and-merge-your-pull-request-commits

hey @maggie0002 just wanted to confirm I didn't consider the merge with rebase workflow so I'll have to see what events this triggers. In the meantime I'd suggest you rebase...

finalize: boolean could default to false.

The only blocker I see for this is that the action uses PR id and commit SHA to tag the release built. Having just a commit SHA to identify a...

I really disliked having the step twice so thank you for realizing that Kyle!

I think the biggest hurdle in solving this issue is that the build action won't return a release ID if we cancel or the build fails so the action has...

https://github.com/balena-io/deploy-to-balena-action/issues/181 would solve this. We could make the trigger a PR like we currently do but make the trigger for finalize a commit by versionbot... I'll have to think about...

I think the easiest and best solution is to have an action that checks if versionbot ran. This new action looks at the main branch and since we know Versionbot...