organice icon indicating copy to clipboard operation
organice copied to clipboard

Can't bookmark specific views as PWA on iOS 15.5

Open jbarbero opened this issue 1 year ago • 3 comments

Describe the bug Can only bookmark the index.html view on iOS 15.5 Mobile Safari.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://organice.200ok.ch/files/foobar in Mobile Safari on iOS 15.5
  2. Click on Share -> Add to Home Screen
  3. URL offered is https://organice.200ok.ch/index.html

Expected behavior The URL offered should be: https://organice.200ok.ch/files/foobar

Smartphone (please complete the following information):

  • Device: iPhone 12
  • OS: iOS 15.5
  • Browser: Safari

Additional context

I think the problem is that the manifest start_url is not being generated correctly here: https://github.com/200ok-ch/organice/blame/master/public/index.html

I will try to debug this, but wanted to post the issue first.

Thanks!

jbarbero avatar Sep 05 '22 04:09 jbarbero

Thanks for the report!

Can't test on iOS but on Android with Firefox, it works.

schoettl avatar Sep 05 '22 19:09 schoettl

I will try to run it myself and submit a fix when I have a moment.

El El lun, sep. 5, 2022 a la(s) 3:40 p.m., Jakob Schöttl < @.***> escribió:

Thanks for the report!

Can't test on iOS but on Android with Firefox, it works.

— Reply to this email directly, view it on GitHub https://github.com/200ok-ch/organice/issues/897#issuecomment-1237416001, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGDCIWAQ43HN5LUDDIACFDV4ZECNANCNFSM6AAAAAAQEUA2CY . You are receiving this because you authored the thread.Message ID: @.***>

jbarbero avatar Sep 06 '22 00:09 jbarbero

I confirm that it does not work on iOS 15.6.1. It definitively used to work. And we had to adapt this once or twice already due to changes in iOS or Android. Not saying that it is not a regression on our side this time. I haven't looked into it, yet.

My old bookmark on the homescreen still works, though.

@jbarbero Thank you for the report :pray:

I will try to run it myself and submit a fix when I have a moment.

That is very kind of you! I'll assign the issue to you, then.

munen avatar Sep 15 '22 09:09 munen