2009scape.github.io icon indicating copy to clipboard operation
2009scape.github.io copied to clipboard

Use templates better to remove a ton of code duplication

Open PureTryOut opened this issue 5 months ago • 6 comments

Where it made sense I converted HTML pages to Markdown to ease writing and discourage custom styling as much as possible. These pages can still use custom HTML when necessary, and some do, but they are easier to read and understand now.

4,882 additions and 12,273 deletions.

Those are the numberse we like to see, love it.

PureTryOut avatar Jan 10 '24 14:01 PureTryOut

@Ceikry anything holding this back?

PureTryOut avatar Jan 20 '24 14:01 PureTryOut

@ryannathans Any opinion? I say we yeet it in

dginovker avatar Jan 23 '24 03:01 dginovker

There are a lot of changes, does this impact my update script MR?

ryannathans avatar Jan 24 '24 12:01 ryannathans

It doesn't. The PR that does though is https://github.com/2009scape/2009scape.github.io/pull/243 which has already been merged, and https://gitlab.com/2009scape/2009scape/-/merge_requests/1710 updates your update script. There is no mention of this script in this repo btw so I had no clue it existed. Is there any reason for not having it in this repo instead of in the server one?

PureTryOut avatar Jan 24 '24 14:01 PureTryOut

@ryannathans and @Ceikry is there anything left to do here?

PureTryOut avatar Feb 18 '24 10:02 PureTryOut

looks good to me.

downthecrop avatar Feb 19 '24 09:02 downthecrop